fix(tenants): use nameEn for English locale on platform admin list#280
Open
abdout wants to merge 1 commit into
Open
fix(tenants): use nameEn for English locale on platform admin list#280abdout wants to merge 1 commit into
abdout wants to merge 1 commit into
Conversation
The /en/tenants page rendered the Arabic school name even when lang=en because the saas-dashboard tenants list went straight to getDisplayText (on-demand translation) without checking school.nameEn first. When the Google Translate fallback failed silently, getDisplayText returned the source Arabic — surfacing as the bug reported in #261. Mirror the canonical pattern from (school-dashboard)/layout.tsx:67-76: prefer the pre-translated school.nameEn for English display, and only fall through to on-demand translation when nameEn is unset. This also removes the per-render translation API call for English viewers of already-translated school names. Closes #261 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/en/tenantspage rendered the Arabic school name even whenlang=en. The saas-dashboard tenants list went straight togetDisplayTextwithout checkingschool.nameEnfirst, and when the Google Translate fallback failed silently,getDisplayTextreturned the source Arabic.src/app/[lang]/s/[subdomain]/(school-dashboard)/layout.tsx:67-76: prefer pre-translatedschool.nameEnfor English locale, fall through to on-demand translation only whennameEnis unset.Changes
src/components/saas-dashboard/tenants/content.tsx: addnameEn: trueto the Prismaselect; prefernameEnfor English locale before callinggetDisplayText.Test plan
/en/tenantsas DEVELOPER → "King Fahad" (or equivalentnameEn) renders for tenants that havenameEnset./ar/tenants, the Arabicnamestill renders (no regression).nameEnset, the existinggetDisplayTexttranslation path still runs.Closes #261